-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Add a tab in Main Page for the Play Queue #2477
Comments
This is a great idea! |
@Wilker-a Material Design Guidelines suggest to use FABs only when the action they link to is very obvious and frequently used, and I don't think the button you suggest to add meets either of these requirements. |
@Stypox the tabs requires the user to go back once and maybe twice if they're browsing a video or searching for one, so i think that makes it a bit more difficult to access without obstructing the other tasks, and i think it would be useful only when the user starts up the app to get a playlist to play with a link for example. one alternative would be to have the menu panel available at all times with a swipe and put the playlist button there, or put it in the 3 dots menu (together with the downloads and settings buttons and stuff). also, making the player itself available at all times like a regular music player is not an option at the moment, because that would obstruct the comments section. unless the user exclusively uses SoundCloud or a service that only plays in the background. |
i think i forgot to mention this: i think the plus button on the playlist could have secondary actions, like a paste button, that automatically takes the link from the clipboard to add the media or the playlist to the queue. whenever pressed. ..on a second thought, i think this would actually be the only function of the plus button (which in this case would be better as a button in the 3 dots menu, and with the chain icon for the link |
The idea is good, i just dont like the fap button. It does not make sense in this context, as there is no list to which you can add items on this screen. I'd rather add an additional menu option that comes with an image and a descriptuon. |
No i ment the second screen that gituby posted. |
I agree with @Stypox. A FAB for this is bad UX and shouldn't be used in this context. |
I think it's a good idea. How about another one? Since we have mini player it can show a list button which shows (after click) a dialog with the play queue. It can be a dialog or a bottomSheet. More importantly by making this way you'll have easy access to the play queue. If you have a tab on main screen you would need to go back to the main screen which is not always useful, for example, when you see some channels and don't want to lose the link to it |
This issue is still not implemented right? I'd be happy to add it as an optional tab on the main page. It will take some time though as I'm not really experienced in Android develpoment so I will have to do some good old docs reading first. |
@andrasfelfoldi yes, this has not been implemented yet; if you are still interested feel free to make a comment and I'll assign you to this issue. |
@andrasfelfoldi I'd be happy to help if you don't have enough time. |
From the guilty creator of the duplicate 7327 after many other duplicates I missed, thank you for getting this addition talked about again. |
@HybridAU I personally find an icon for play queue on the top right corner of info thumbnail as a more logical place. Wdyt? |
Hey @SameenAhnaf that does seem like a good spot for the icon, but essentially the main reason I went with a button in the main menu rather than create a tab or add an icon in the top right was that it was the easiest change with the minimum amount of code required. I haven't done much work with Java so I'm not sure how hard it would be to add a button there, but you would need to be sure that it was only visible and active while the overlay showing the play button was active, you wouldn't want it to show over a video while it's playing, or be active (but not shown) and people accidentally open the play list by tapping on the video. My gut feeling is that would be harder to implement and maintain. |
Hi NewPipe Team,
I wish to make a suggestion for a feature in the main page content. Could it be possible to add in the main content page, a tab for the background player to be able to access it easily (picture 1).
For this, in the parameters menu "Content of Main Page", when clicking on the "+" there could be a new option to add a tab to access directly the background player (picture 2). This will let the user decide to show this tab or not as he wish.
Thanks for reading
The text was updated successfully, but these errors were encountered: