-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support New Yt trending pages #1805
Comments
Looks good to me! One thing though: There is still a main Trending page. Can you access it by pressing Trends, and expand the list by tapping on the arrow? Or would we title it Kiosks, and add Trends on the same level as Music, Sports and Live? |
I think it was awesome if the kiosk could be togfled, meaning the last selected kiosk will be shown beside the arrow, and if someone clicks on it he can sellect one of the other ones |
@theScrabi Hm yeah, I think that makes sense! |
Anyone already working on this? |
Alright, will get working on it then. Can you confirm to me that if you go to Trending News, you also get the URLhttps://www.youtube.com/feed/trending?bp=4gIuCggvbS8wNWpoZxIiUEwzWlE1Q3BOdWxRa2lqaUkwSWxMc0I0R3NQWjhUNVlDZA%3D%3D Edit: |
I solved the above problem by using an URL shortener... but that's not the best solution. Any ideas? Edit: This is the extractor URL. Parse this: implementation 'com.github.Somethingweirdhere:NewPipeExtractor:d024434fcbcb2656b23e181fc2b5485a134b3d49' To test it. It works, but before making a pull request I think we should do something about the links instead of using bit.ly. |
I can verify that the News link you provided is the same for me. Although trending pages differ depending on region. I would probably recommend hardcoding the links rather than using a link shortener, similar to what is currently done in SearchQueryHandler, so instead of For something more robust, I would probably recommend taking a look at TeamNewPipe/NewPipeExtractor#106, as it appears to be quite similar. Although I haven't investigated very much, this appears to be the structure of the
Where SIZE is a single byte indicating the length of the indented data (in bytes). Notice that each trending param actually refers internally to a playlist, examples:
|
@omarroth I have already tried that: gregordr/NewPipeExtractor@3fcf812 The issue is that apparently everything after the ? get's ignored |
Ah, I missed that. Sorry that I won't be much help there. |
@theScrabi @TobiGr @karyogamy What do you think about this? Merge this way? Try to find out why the ? are being ignored? Any other thoughts? |
I may look at this, but atm it has rather low priority. |
Goodness I swear this didn't come up when I made my issue! Ah well nice issue |
Youtube has recently introduced new trending pages
This now makes it possible to also see topic related trending, like music, live stream, news etc. Since I think this is (at least) something good youtube did we should add support for this.
NewPipe is written to support more than only one of these "Kiosks" per service, so it should be pretty simple to just add some more kisoks to the extractor.
This should not be to much complicated, and it is a welcome thing for getting in touch with the extractor.
Optional UI changes
Short or long term we need to change the UI to better support multiple Kiosks. @Somethingweirdhere what do you think about my suggestion?
The text was updated successfully, but these errors were encountered: