Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable services in the configuration #1116

Open
2 tasks done
ghost opened this issue Feb 16, 2018 · 19 comments
Open
2 tasks done

Disable services in the configuration #1116

ghost opened this issue Feb 16, 2018 · 19 comments
Labels
feature request Issue is related to a feature in the app

Comments

@ghost
Copy link

ghost commented Feb 16, 2018

  • I carefully read the contribution guidelines and agree to them.
  • I checked if the issue/feature exists in the latest version.

I love that Newpipe has the possibility of using multiple services, but what happens if someone prefers to use certain services and not others? It would be nice to add a section in the configuration to disable services

@justanidea
Copy link
Contributor

Or to download only the section you want, to make the app as light as possible :)

@theScrabi
Copy link
Member

Yes when there are more than only two services this is something we can consider.

@stale

This comment has been minimized.

@stale stale bot added the stale label Dec 1, 2018
@Stypox Stypox added the feature request Issue is related to a feature in the app label Jul 18, 2019
@TobiGr TobiGr removed the stale label Jul 19, 2019
@triallax
Copy link
Contributor

NewPipe currently has five services, so I think this is worth re-visiting.

@litetex litetex changed the title [Feature Request] disable services in the configuration Disable services in the configuration Mar 23, 2022
@FletcherD
Copy link

FletcherD commented May 12, 2022

I think that this is fairly necessary, because we currently cannot use the Bandcamp cart or buy anything without this, unless we disable Newpipe altogether.

@hermitical
Copy link

This should definitely be given attention. I do not wish to use NewPipe for Bandcamp, this leads to NewPipe hijacking links and literally makes it impossible to access Bandcamp properly when going through a browser (as you annoyingly have to for some things on Bandcamp)

@triallax
Copy link
Contributor

@FletcherD @hermitical what Android versions do you have? In Android 12, you are able to enable certain links for any given apps, while keeping the others disabled. For instance, you can make NewPipe handle youtube.com links, but not *.bandcamp.com ones. I don't know if you can do something similar in earlier Android versions though, so you'll have to do some research.

@Wyntilda
Copy link

While this is a setting in newer versions of Android, NewPipe doesn't seem to restrict itself to just the allowed links. I only allow YouTube links for NewPipe and it still opens Bandcamp links. There doesn't seem to be a way to disable this from happening.

@opusforlife2
Copy link
Collaborator

@Wyntilda In Android 12+ you can select exactly which links you want apps to be able to open from a list.

@Wyntilda
Copy link

Wyntilda commented Dec 2, 2022

@opusforlife2 I'm aware; what I'm saying is that Bandcamp is not on the allowed links list for NewPipe, only YouTube links are, yet NewPipe still opens Bandcamp links.

@opusforlife2
Copy link
Collaborator

Oh wow. And clearing defaults for link opening settings has no effect on this? Do you have the Bandcamp app installed? Have you tried Firefox, if you're using Chrome?

@PigDan20
Copy link

PigDan20 commented Feb 4, 2023

This should definitely be given attention. I do not wish to use NewPipe for Bandcamp, this leads to NewPipe hijacking links and literally makes it impossible to access Bandcamp properly when going through a browser (as you annoyingly have to for some things on Bandcamp)

This same thing has been happening to me and just now it's becoming too much. It's very, very annoying and makes navigating certain webpages or apps impossible due to the URL opening feature. The Android app setting adjustments do absolutely nothing to turn this off from a user's perspective, so NewPipe is causing the issues likely. Like what was said earlier, any Bandcamp URL opened on a Bandcamp webpage in Firefox (or I assume anywhere else in Android) automatically opens up the NewPipe overlay, whether that's a link to a musician's albums or elsewhere. I'm also guessing this happens to other links NewPipe is programmed to respond to.

Any suggestions to make this go away, or plans from the devs to add proper customization to optionally turn off URL opening altogether? On Android 13 now. I think for the most part NewPipe works fine besides this issue.
Edit: also, this relates to the original post as I would really like that customization which still apparently doesn't exist.

In the meantime, unfortunately I must uninstall NewPipe.

@opusforlife2
Copy link
Collaborator

@fynngodau Could you check why this is happening?

@fynngodau
Copy link
Member

@opusforlife2 On my Android 13 device, turning off the "*.bandcamp.com" URL for NewPipe in the system settings has the desired effect, i.e. NewPipe no longer opens when clicking links elsewhere in the system, and after adding the link again, NewPipe is always opened (note that there is no way to have a picker for this natively anymore, unfortunately). It is unclear to me why this does not work for the other commenters.

In any case, I believe that NewPipe can not solve the problem because the links that and app handles are hardcoded in the manifest and can't be changed at runtime. The only option I see would be to open the browser from within NewPipe automatically for some links if the user wishes so – which I consider is a not-so-sensical option, because we really wouldn't want every app to implement this, as figuring out which app should handle an intent / a link is a task that belongs to the Android system.

@PigDan20
Copy link

PigDan20 commented Feb 4, 2023

@opusforlife2 On my Android 13 device, turning off the "*.bandcamp.com" URL for NewPipe in the system settings has the desired effect, i.e. NewPipe no longer opens when clicking links elsewhere in the system, and after adding the link again, NewPipe is always opened (note that there is no way to have a picker for this natively anymore, unfortunately). It is unclear to me why this does not work for the other commenters.

In any case, I believe that NewPipe can not solve the problem because the links that and app handles are hardcoded in the manifest and can't be changed at runtime. The only option I see would be to open the browser from within NewPipe automatically for some links if the user wishes so – which I consider is a not-so-sensical option, because we really wouldn't want every app to implement this, as figuring out which app should handle an intent / a link is a task that belongs to the Android system.

Are you referring to this screen or a different one in the Android 13 setting menu? No adjustments here do anything to fix this collective issue. (Also reinstalled the app to see if it would fix anything.. nope, unfortunately!). And to clarify on earlier -- when I say it opens every Bandcamp link on the website, it really does (to such an extent where I'm surprised it's apparently so rarely mentioned online!).. it either says it's Unsupported URL or opens the other pop-up, I guess for Downloading or Info.

Screenshot_20230204_164757_Settings

@fynngodau
Copy link
Member

@PigDan20 Indeed, this is the settings page I am referring to.

Your Android flavor seems to not be AOSP-like, and I suspect this to be a bug that your device manufacturer is responsible for. Could you specify your device model, please?

@PigDan20
Copy link

PigDan20 commented Feb 6, 2023

@PigDan20 Indeed, this is the settings page I am referring to.

Your Android flavor seems to not be AOSP-like, and I suspect this to be a bug that your device manufacturer is responsible for. Could you specify your device model, please?

Oh, ok yeah, so it definitely is unresponsive then. Thanks for the reply, appreciated. It does seem like a bug. Edit: could've sworn I mentioned my phone name earlier but I think the comment editing had an error, so here it is!

Screenshot_20230205_213709_Settings

@fynngodau
Copy link
Member

@PigDan20 I was only able to test on a Samsung Galaxy S22 Ultra with Android 12, not Android 13. On this device, the described behavior was not the case, and both unchecking "*.bandcamp.com" under Supported web addresses, as well as disabling the "Open supported links" toggle entirely, both caused links to no longer be opened in NewPipe.

@PigDan20
Copy link

PigDan20 commented Feb 6, 2023

@PigDan20 I was only able to test on a Samsung Galaxy S22 Ultra with Android 12, not Android 13. On this device, the described behavior was not the case, and both unchecking "*.bandcamp.com" under Supported web addresses, as well as disabling the "Open supported links" toggle entirely, both caused links to no longer be opened in NewPipe.

Right. Strange, yeah that's the thing I was testing earlier. But I did this again -- actually both are automatically turned off -- but I enabled and disabled both and this described behavior still happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests