Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nightly] crashes when trying to load the comments #10888

Closed
6 tasks done
throwaway242685 opened this issue Mar 17, 2024 · 9 comments · Fixed by TeamNewPipe/NewPipeExtractor#1162
Closed
6 tasks done
Labels
bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios GUI Issue is related to the graphical user interface

Comments

@throwaway242685
Copy link

throwaway242685 commented Mar 17, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.26.1

Steps to reproduce the bug

  1. enable the "Show Comments" option.
  2. go to random videos and try to read the comments.
  3. it will crash almost instantly.

Logs

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: US
  • Content Language: en-US
  • App Language: en_US
  • Service: none
  • Version: 0.26.1
  • OS: Linux Android 9 - 28
Crash log

java.lang.NullPointerException: Attempt to invoke virtual method 'int org.schabi.newpipe.extractor.stream.Description.getType()' on a null object reference
	at org.schabi.newpipe.util.text.TextLinkifier.fromDescription(TextLinkifier.java:70)
	at org.schabi.newpipe.util.text.TextEllipsizer.linkifyContentView(TextEllipsizer.java:166)
	at org.schabi.newpipe.util.text.TextEllipsizer.setContent(TextEllipsizer.java:62)
	at org.schabi.newpipe.info_list.holder.CommentInfoItemHolder.updateFromItem(CommentInfoItemHolder.java:127)
	at org.schabi.newpipe.info_list.InfoListAdapter.onBindViewHolder(InfoListAdapter.java:337)
	at androidx.recyclerview.widget.RecyclerView$Adapter.onBindViewHolder(RecyclerView.java:7747)
	at androidx.recyclerview.widget.RecyclerView$Adapter.bindViewHolder(RecyclerView.java:7847)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryBindViewHolderByDeadline(RecyclerView.java:6646)
	at androidx.recyclerview.widget.RecyclerView$Recycler.tryGetViewHolderForPositionByDeadline(RecyclerView.java:6917)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6757)
	at androidx.recyclerview.widget.RecyclerView$Recycler.getViewForPosition(RecyclerView.java:6753)
	at androidx.recyclerview.widget.LinearLayoutManager$LayoutState.next(LinearLayoutManager.java:2362)
	at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1662)
	at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4645)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4348)
	at androidx.recyclerview.widget.RecyclerView.onLayout(RecyclerView.java:4919)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.RelativeLayout.onLayout(RelativeLayout.java:1083)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at androidx.viewpager.widget.ViewPager.onLayout(ViewPager.java:1775)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at com.google.android.material.appbar.HeaderScrollingViewBehavior.layoutChild(HeaderScrollingViewBehavior.java:149)
	at com.google.android.material.appbar.ViewOffsetBehavior.onLayoutChild(ViewOffsetBehavior.java:43)
	at com.google.android.material.appbar.AppBarLayout$ScrollingViewBehavior.onLayoutChild(AppBarLayout.java:2381)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.layoutChild(CoordinatorLayout.java:1213)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayoutChild(CoordinatorLayout.java:899)
	at com.google.android.material.bottomsheet.BottomSheetBehavior.onLayoutChild(BottomSheetBehavior.java:576)
	at androidx.coordinatorlayout.widget.CoordinatorLayout.onLayout(CoordinatorLayout.java:918)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at androidx.drawerlayout.widget.DrawerLayout.onLayout(DrawerLayout.java:1263)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1812)
	at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1656)
	at android.widget.LinearLayout.onLayout(LinearLayout.java:1565)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.widget.FrameLayout.layoutChildren(FrameLayout.java:323)
	at android.widget.FrameLayout.onLayout(FrameLayout.java:261)
	at com.android.internal.policy.DecorView.onLayout(DecorView.java:1075)
	at android.view.View.layout(View.java:22406)
	at android.view.ViewGroup.layout(ViewGroup.java:6594)
	at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:3396)
	at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2863)
	at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:1911)
	at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8528)
	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:949)
	at android.view.Choreographer.doCallbacks(Choreographer.java:761)
	at android.view.Choreographer.doFrame(Choreographer.java:696)
	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:935)
	at android.os.Handler.handleCallback(Handler.java:873)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7091)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:975)


Affected Android/Custom ROM version

Android 9

Affected device model

Samsung Galaxy A10

Additional information

I think this bug is related to the implementation of replies.

it's a bug that only exists in Nightly.

@throwaway242685 throwaway242685 added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Mar 17, 2024
@TheMCNerd2017
Copy link

I have the same issue and even reported it as well a few months ago (thinking it was rare random crash due to a YouTube A/B test) however it was closed due to the crash not occurring on the stable build. From my experience there are many actions that trigger this crash including: loading any video, viewing the description of a video, going to another video in a playlist, listening to a playlist in the background, scrolling down in the comments section.

Additionally when this crash occurs, saved playlists and potentially other data seem to revert to an older state.

@opusforlife2
Copy link
Collaborator

#10808

@opusforlife2 opusforlife2 added duplicate Issue or discussion is a duplicate of an existing issue or discussion and removed bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Mar 26, 2024
@AudricV
Copy link
Member

AudricV commented Mar 26, 2024

@opusforlife2 No, that's not the same issue, it's an app bug. even if it can be reproduced by being hit with YT A/B test: read the stacktrace. Reopening.

@AudricV AudricV reopened this Mar 26, 2024
@AudricV AudricV added bug Issue is related to a bug GUI Issue is related to the graphical user interface and removed duplicate Issue or discussion is a duplicate of an existing issue or discussion labels Mar 26, 2024
@opusforlife2
Copy link
Collaborator

Is this the one where scrolling down comments a few times caused a crash? I think that's already reported somewhere.

@throwaway242685
Copy link
Author

throwaway242685 commented Mar 26, 2024

@opusforlife2 I'll record a video of this bug, but no, it's not the same bug that you mentioned.

just wait me a few minutes.

@throwaway242685
Copy link
Author

throwaway242685 commented Mar 26, 2024

20240326_165000.mp4

it crashes almost instantly after opening the video.

a few notes:

  1. this bug only exists in Nightly.
  2. it only happens if you have "Show Comments" enabled.

so... I guess it's a bug related to the implementation of replies?

@opusforlife2
Copy link
Collaborator

Oh okay. Then yeah, probably.

@throwaway242685

This comment has been minimized.

@TobiGr
Copy link
Contributor

TobiGr commented Mar 31, 2024

The extractor version has not been updated in the app source code yet.

@ShareASmile ShareASmile added the comments Anything to do with comments and comment replies under videos/audios label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios GUI Issue is related to the graphical user interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants