Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters shouldn't be hard-coded in the module #4

Closed
giordano opened this issue Feb 27, 2020 · 1 comment · Fixed by #5
Closed

Parameters shouldn't be hard-coded in the module #4

giordano opened this issue Feb 27, 2020 · 1 comment · Fixed by #5
Assignees
Labels
enhancement New feature or request

Comments

@giordano
Copy link
Member

We currently have the file src/params.jl with parameters hard-coded into the module.

I did this in the quick proof-of-concept following the example of the original code, but in the long term this is not a good practice. Maybe read from a file?

@tkoskela tkoskela added the enhancement New feature or request label Feb 28, 2020
@tkoskela
Copy link
Member

This is needed to test more of the code's functions since we can't override the parameters for smaller test runs right now.

@tkoskela tkoskela self-assigned this Mar 9, 2020
@giordano giordano linked a pull request Jun 16, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants