Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add branchname to pathname #67

Open
Tom-van-Woudenberg opened this issue Dec 4, 2024 · 1 comment
Open

Add branchname to pathname #67

Tom-van-Woudenberg opened this issue Dec 4, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@Tom-van-Woudenberg
Copy link
Member

As far as I understand, the path name is everything which follows on the baseurl. If the baseurl is set to <user/organization>.io/ then the pathname is everything which follows after. I think this is defined somewhere in the html files. Maybe it's this line?

<html lang="en" data-content_root="../../" >

it seems that pathname is used at least for the utterances script. It takes the baseurl in _config.yml and pastes the pathname after it:
image
However, the path name is not included. This results in this utterances script redirecter back to the page on root always, instead of to the page on the specific branch.
@Tom-van-Woudenberg Tom-van-Woudenberg added the enhancement New feature or request label Dec 8, 2024
@Tom-van-Woudenberg
Copy link
Member Author

It seems that the pathname is also using for the Open Issue button. This not creates an issue with the pathname, which doesn't include the branch-part of the URL)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Deploy book workflow
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tom-van-Woudenberg