Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML output is missing HTML5 Doctype #3125

Closed
jonaskohl opened this issue Apr 26, 2024 · 1 comment
Closed

HTML output is missing HTML5 Doctype #3125

jonaskohl opened this issue Apr 26, 2024 · 1 comment

Comments

@jonaskohl
Copy link

Tandoor Version

1.15.17

Setup

Docker / Docker-Compose

Reverse Proxy

Nginx Proxy Manager (NPM)

Other

No response

Bug description

The HTML output by Tandoor is missing the HTML5 Doctype (<!DOCTYPE html>). This makes the page render in quirks mode, which in turn creates unexpected results when creating themes. Thus, the site should include the <!DOCTYPE html> doctype declaration.

At the moment, the first few lines look like this:






<html>
<head>
    <title>Suchen</title>
    <meta charset="utf-8">
    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no, viewport-fit=cover">
    <meta name="robots" content="noindex,nofollow"/>

    <link rel="icon" href="/media/files/1337a83f-902b-4f9f-bf5a-25189488fd37.svg">
    <link rel="icon" href="/media/files/90604135-dd4b-4cae-9494-97293fcd3bf9.png" sizes="32x32">
    <link rel="icon" href="/media/files/e68256be-fac1-4fb0-aeff-ab3e0198f3cf.png" sizes="128x128">
    <link rel="icon" href="/media/files/b339747f-2b3e-46b8-a8cd-0432dfa4efbe.png" sizes="192x192">
    <link rel="apple-touch-icon" href="/media/files/7e52f283-4505-4955-9172-bbbabd3d9b24.png" sizes="180x180">

    <link rel="manifest" crossorigin="use-credentials" href="/manifest.json">

    <meta name="msapplication-TileColor" content="#a2dd73">
    <meta name="msapplication-TileImage" content="/media/files/799559b0-e045-439f-a24f-2c37502a508e.png">

    <meta name="theme-color" content="#a2dd73">

    <meta name="apple-mobile-web-app-capable" content="yes"/>

Relevant logs

No response
@vabene1111
Copy link
Collaborator

thanks, never noticed that, fixed in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vabene1111 @jonaskohl