Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank select listbox when re-opening in Firefox. #892

Open
2 tasks done
DipperTheDan opened this issue Dec 5, 2024 · 0 comments
Open
2 tasks done

Blank select listbox when re-opening in Firefox. #892

DipperTheDan opened this issue Dec 5, 2024 · 0 comments

Comments

@DipperTheDan
Copy link

Describe the bug

If we reopen our Select listbox after scrolling down past the overscan value, the listbox has no options rendered. They appear in the DOM but not in the listbox. If you scroll even by 1px once reopened, the options render (I have attached a screen recording of this further down).

Your minimal, reproducible example

https://stackblitz.com/edit/parsium-carbon-starter-zza8bg?file=src%2FApp.tsx

Steps to reproduce

  1. Open Firefox and navigate to our Select virtualised example or the reproducible Stackblitz example

  2. Click the Select's component textbox to open it and scroll down beyond option 30 (the overscan value is 20, so a whole new list of options is rendered there)

  3. Close the listbox. This can be done by clicking away from the listbox.

  4. Click the Select's component textbox to reopen Select's listbox.

Actual Result:

Listbox is initially blank.

Expected Result:

Options to be visible.

Expected behavior

I expect there to be options in the listbox.

How often does this bug happen?

Every time

Screenshots or Videos

Firefox:
https://github.com/user-attachments/assets/6c2022b4-d56e-4bb0-925a-fbcfeb211839

Chrome:
https://github.com/user-attachments/assets/ed5d48c0-289c-42af-a84a-cc96de273fcb

Firefox but I scroll a small amount when reopening:
https://github.com/user-attachments/assets/6d7ba0f6-6540-4ac7-bb2a-3cc1ce763759

Platform

Operating Systems:

  • MacOS
  • Windows

Web Browser:

  • Firefox (I am using v133.0)

tanstack-virtual version

v3.10.1

TypeScript version

v4.7.0

Additional context

I was able to fix this bug using the code below. However, I was not prepared to merge it into our codebase as I don't think browser sniffing is a particularly good fix for this. Without the conditional check for Firefox, this would break our implementation on Chrome, Safari and Edge.

This is what seemed to fix it:

const SCROLL_OPTIONS: ScrollToOptions = { behavior: "auto", align: "end" };

const browserIsFirefox =
      navigator.userAgent.toLowerCase().indexOf("firefox") > -1;

    useEffect(() => {
      if (browserIsFirefox && isOpen && currentOptionsListIndex === -1) {
        virtualizer.scrollBy(0, SCROLL_OPTIONS);
      }
    });

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant