From d5bd5ba2ae8c60a1a497333a7161e00be625ef42 Mon Sep 17 00:00:00 2001 From: Andrew Cherniavskii Date: Thu, 27 Feb 2020 21:17:15 +0100 Subject: [PATCH 1/2] add failing test --- src/tests/useQuery.test.js | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/src/tests/useQuery.test.js b/src/tests/useQuery.test.js index 64fdaa229b..1358fae12d 100644 --- a/src/tests/useQuery.test.js +++ b/src/tests/useQuery.test.js @@ -157,4 +157,26 @@ describe('useQuery', () => { await waitForElement(() => rendered.getByText('default')) expect(queryFn).not.toHaveBeenCalled() }) + + it('should set status to error if queryFn throws', async () => { + function Page() { + const { status } = useQuery( + 'test', + () => { + return Promise.reject('Error test') + }, + { retry: false }, + ) + + return ( +
+

{status}

+
+ ) + } + + const rendered = render() + + await waitForElement(() => rendered.getByText('error')) + }) }) From abe00285ecd78028f459ce69ed0bda0c0745a265 Mon Sep 17 00:00:00 2001 From: Andrew Cherniavskii Date: Thu, 27 Feb 2020 21:18:01 +0100 Subject: [PATCH 2/2] fix failing test --- src/queryCache.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/queryCache.js b/src/queryCache.js index af298ae7bc..da4ed81850 100644 --- a/src/queryCache.js +++ b/src/queryCache.js @@ -306,7 +306,7 @@ export function makeQueryCache() { }) } - // throw error + throw error } } @@ -381,7 +381,7 @@ export function makeQueryCache() { instance.onSettled && instance.onSettled(undefined, error) ) - throw error + // throw error } } })()