Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to resolve entry for package "@tanstack/solid-query" when upgrading to solid-query 5.0.0 #5612

Closed
MattJustMatt opened this issue Jun 19, 2023 · 3 comments

Comments

@MattJustMatt
Copy link
Contributor

Describe the bug

I’m trying to migrate a small project I wrote with solid-query from v4 to v5. I’ve tried wiping node_modules and starting fresh but Vite can’t bundle solid-query for some reason with the error in the title.

Your minimal, reproducible example

//

Steps to reproduce

Install solid-query latest alpha,
Try to include it in a Vite bundled project

Expected behavior

Normal behavior with the new API

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

Windows,
SolidJS project using the solid vite template

Tanstack Query adapter

solid-query

TanStack Query version

Alpha 68

TypeScript version

4.9.5

Additional context

No response

@MattJustMatt
Copy link
Contributor Author

It looks like there's a typo in the path for the solid entry js file:

https://github.com/TanStack/query/blame/7c61693d6f76adb3d015ed97ce0045fe47df174f/packages/solid-query/package.json#L20

I believe this should be .js. Modifying gets me building again

@ardeora
Copy link
Contributor

ardeora commented Jun 22, 2023

Thanks for working on this! Should be fixed in v5.0.0-alpha.69

Could you please check and confirm? 😄

@MattJustMatt
Copy link
Contributor Author

Thanks for merging! Tested locally and good to go! Fresh npm install with no errors

@TkDodo TkDodo closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants