Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spread field errors on form onMount validator #1079

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Balastrong
Copy link
Member

Fixes #1055

Copy link

nx-cloud bot commented Dec 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b2b86db. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1079

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1079

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1079

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1079

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1079

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1079

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1079

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1079

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1079

commit: b2b86db

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (4503caf) to head (b2b86db).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
+ Coverage   86.61%   86.79%   +0.18%     
==========================================
  Files          29       29              
  Lines        1158     1159       +1     
  Branches      297      299       +2     
==========================================
+ Hits         1003     1006       +3     
+ Misses        142      140       -2     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Balastrong Balastrong merged commit ab9dd76 into TanStack:main Dec 16, 2024
7 checks passed
@Balastrong Balastrong deleted the fix/form-mount-field-errors branch December 16, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form-level useMount validator does not trigger field-level errors
1 participant