chore: allow unusedLocals in standard-schema example #1068
Conversation
there were a bunch ts-ignores, which looks bad on an example
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 008ff09. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
There was a problem hiding this comment.
I don't think the ts-ignores look bad in the example, in fact we're intentionally writing wrong code with unused variables for demo purposes.
Another option I evaluated was to keep all the unused stuff commented, but then it meant you had to uncomment both the schema and the import each time, not ideal.
With that said, I see it might cause some confusion so maybe allowing the error at a linter level might make the example easier to read but still, we're allowing an error.
I'll think about it, the example is just about showing how easy it's to swap them, I might merge this. Thanks for the suggestion!
there were a bunch ts-ignores, which looks bad on an example
Personally I prefer policing unused locals via a linter, which helps assign more appropriate "seriousness" to tsc errors, and so unused local errors can be more easily suppressed, but that's just me so I didn't make a sweeping change here.