Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Pytest modifies and updates search_library sqlite file #644

Closed
3 tasks done
CyanVoxel opened this issue Dec 14, 2024 · 0 comments · Fixed by #648
Closed
3 tasks done

[Bug]: Pytest modifies and updates search_library sqlite file #644

CyanVoxel opened this issue Dec 14, 2024 · 0 comments · Fixed by #648
Labels
Priority: High An important issue requiring attention Status: Help Wanted Extra attention is needed Type: Bug Something isn't working as intended Type: Tests Tests or testing related

Comments

@CyanVoxel
Copy link
Member

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

Alpha v9.5.0 (main branch)

Operating System & Version

Windows 10

Description

Running Pytest (specifically one or more of the search_library tests) results in the test database being modified, resulting in git wanting to commit the changes.
The internal change seems to be a result of the file change counter value being updated.

Expected Behavior

The test database should not be changed on disk, especially when no changes are being made to it. It should also not be included in the .gitignore because the file in question can receive genuine updates and changes.

Steps to Reproduce

  1. Clone and set up a TagStudio development environment per the CONTRIBUTING.md instructions
  2. Run Pytest with pytest tagstudio/tests/
  3. Observe modified file at \TagStudio\tagstudio\tests\fixtures\search_library\.TagStudio\ts_library.sqlite

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High An important issue requiring attention Status: Help Wanted Extra attention is needed Type: Bug Something isn't working as intended Type: Tests Tests or testing related
Projects
Status: ✅ Done
1 participant