Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Tag aliases allow blank string values #627

Closed
3 tasks done
CyanVoxel opened this issue Dec 4, 2024 · 0 comments · Fixed by #628
Closed
3 tasks done

[Bug]: Tag aliases allow blank string values #627

CyanVoxel opened this issue Dec 4, 2024 · 0 comments · Fixed by #628
Assignees
@CyanVoxel
Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended
Milestone
SQL Parity

Comments

@CyanVoxel
Copy link
Member

Checklist

  • I am using an up-to-date version.
  • I have read the documentation.
  • I have searched existing issues.

TagStudio Version

main branch (v9.5.0)

Operating System & Version

macOS 15.1.1

Description

Currently, tag aliases allow for blank string values in the database. When converting over JSON libraries, this also adds several blank alias entries into the database.

Expected Behavior

Empty values ("", NONE, etc.) should not be allowed as alias names as they are unhelpful and clog up the database with unintentional and meaningless values.

Steps to Reproduce

  1. Have a JSON database with several user-created tags that do not contain aliases
  2. Migrate JSON db to SQL
  3. Open SQL db in an appropriate SQLite viewing application or plugin (I used SQLite Viewer for VSCode)
  4. Observe the empty string values in alias name rows

Logs

No response
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended TagStudio: Library Relating to the TagStudio library system Priority: High An important issue requiring attention TagStudio: Tags Relating to the TagStudio tag system labels Dec 4, 2024
@CyanVoxel CyanVoxel added this to the SQL Parity milestone Dec 4, 2024
@CyanVoxel CyanVoxel self-assigned this Dec 4, 2024
@CyanVoxel CyanVoxel mentioned this issue Dec 4, 2024
Merged
@CyanVoxel CyanVoxel moved this to 🚧 In progress in TagStudio Development Dec 4, 2024
@github-project-automation github-project-automation bot moved this from 🚧 In progress to ✅ Done in TagStudio Development Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CyanVoxel CyanVoxel

Labels
Priority: High An important issue requiring attention TagStudio: Library Relating to the TagStudio library system TagStudio: Tags Relating to the TagStudio tag system Type: Bug Something isn't working as intended
Projects
TagStudio Development
Status: ✅ Done
Milestone
SQL Parity
Development

Successfully merging a pull request may close this issue.

fix: don't allow blank tag alias values in db (Fix #627) TagStudioDev/TagStudio
1 participant
@CyanVoxel