Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement cp ( refactoring) #120

Open
2 of 6 tasks
luke-moth opened this issue Jan 16, 2023 · 1 comment
Open
2 of 6 tasks

implement cp ( refactoring) #120

luke-moth opened this issue Jan 16, 2023 · 1 comment

Comments

@luke-moth
Copy link
Contributor

luke-moth commented Jan 16, 2023 •
edited
Loading

placeholder issue for 6 scopes

OUTLINE SCOPES

  • scope1: architectuur
  • scope2: get_recorded_activity_df
    • WIP branch CP-scope-2-rec-act
  • scope3: get_activity_graph + compute_critical_path (note activity_graph >> simulation_graph (incl. activities and dependencies)
  • scope4: DependenciesFromLog

UPDATE 28th Feb: Change order (first 6 then 5)

  • scope6: DependenciesFromSimpy
  • scope5: DependenciesFromModel

Example production code

my_env = MyCustomSimpyEnv()
# OR
my_env = simpy.Environment()

# simulation code
# ...

# call CP functionality
cp_log = DependenciesFromModel(...)  # OR 1 of other classes that inherits
critical_path_df = cp_log.get_critical_path_df()
plot.gantt_chart(critical_path_df)
@luke-moth luke-moth changed the title scope 3: implement cp (formerly mark_critical_activities) implement cp (formerly mark_critical_activities) Jan 23, 2023
@luke-moth luke-moth changed the title implement cp (formerly mark_critical_activities) implement cp ( refactoring) Jan 23, 2023
@ariedeniet
Copy link

ariedeniet commented May 8, 2023 •
edited
Loading

@luke-moth scope3, scope4 and scope6 can be marked done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ariedeniet @luke-moth