Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review workflows needing APP_ID and etc since move to organization #1108

Open
tupaschoal opened this issue Jan 5, 2025 · 1 comment
Open

Comments

@tupaschoal
Copy link
Collaborator

tupaschoal commented Jan 5, 2025

Some workflows are failing, likely because the APP_ID and APP_PRIVATE_KEY are unaccessible (?) such as here:

- uses: tibdex/github-app-token@v2
id: generate-token
with:
app_id: ${{ secrets.APP_ID }}
private_key: ${{ secrets.APP_PRIVATE_KEY }}

We need to make sure this is properly set for it to start working again. Additionally, it seems GH has released an official action for generating tokens, so we should convert to that for security reasons.

https://github.com/actions/create-github-app-token

Here's the path to create a new app https://github.com/organizations/TTLApp/settings/apps/new

@thamara
Copy link
Collaborator

thamara commented Jan 5, 2025

I've transferred the APP to the organization and installed it. Now the changelog updater is working as expected. But I'll keep this open as I want to review how we are doing things and how to move to the official token generation.

@thamara thamara changed the title Functionalize workflows needing APP_ID and etc since move to organization Review workflows needing APP_ID and etc since move to organization Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants