-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added offline font. #1034
Added offline font. #1034
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
==========================================
+ Coverage 79.37% 79.40% +0.03%
==========================================
Files 21 21
Lines 1275 1277 +2
Branches 189 189
==========================================
+ Hits 1012 1014 +2
Misses 263 263 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
It seems we only require two of the fonts from the family.
Could we commit only these two then?
And could you document in the .css file where you got it from, in case we need the other fonts in the future?
package-lock.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't need to be committed, nothing changed in the package.
Sorry it appears I didn't explain well. It only uses those 2 fonts when offline not the entire family. And yes I can document it. |
In that case, let's commit only those two we need and not the whole family to have a smaller footprint in the repo. |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to change styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed to change styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chase-west can you please undo any changes on the package-lock.json
? It should have not been necessary to touch it for the PR
I honestly have no idea how to do that I've tried |
https://devconnected.com/how-to-remove-files-from-git-commit/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@araujoarthur0 I have reverted the changes to package-lock.json
, but I haven't tested the PR, can you check, please?
I've also changed the PR to use the variable weight font instead. @thamara, could you check in Mac if the text sizes look the same before and after this PR? |
\changelog-update |
Thank you all. |
Related issue
Closes #1031
Context / Background
What change is being introduced by this PR?
How will this be tested?
Check if font works when offline.