Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All present button broken #1034

Open
nk-coding opened this issue May 24, 2024 · 1 comment
Open

All present button broken #1034

nk-coding opened this issue May 24, 2024 · 1 comment

Comments

@nk-coding
Copy link
Collaborator

The "all present" button seems to be broken, however investigation required here

@nk-coding nk-coding added 🐞 bug Something isn't working 🧸 good first issue Good for newcomers ↗ Priority: High ❓ Still an issue? Maybe an other contribution has also fixed this one. Needs investigation labels May 24, 2024
@Morphenoed
Copy link
Contributor

Morphenoed commented Jun 7, 2024

✔️ Expected behaviour

After clicking on all present button, the attendances of all students that are undefined are set to present.

⚡ Actual behaviour

Something goes wrong and even though the view is updated, the database entries are not.
After page reload there are only 2-4 random students whose attendances were set to present.

🕹️ Steps to reproduce

  1. Click all present
  2. Reload
  3. Aaaand... broken...

💡 My thoughts

The problem does not lie within all present button, but rather in how the async updates are performed.
If you set a breakpoint before the return of updateAttendance in student.controller and set attendances of several students in the attendance page of a tutorial, not every attendance will be updated after page reload.

@nk-coding nk-coding removed the ❓ Still an issue? Maybe an other contribution has also fixed this one. label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants