You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After making sure framework.assets.base_urls is used in the ThemeBundle, I found out today that the imagine_filter is still generating URL's based on the app's base URL, and not on the defined asset URL. This is something ImagineBundle itself also doesn't support, so it's not strictly a Sylius bug. Though, it prevents full usage of a CDN inside Sylius out of the box.
I didn't get a working solution yet to decorate the WebPathResolver of ImagineBundle. While trying to decorate I wanted to use the UrlPackage of the theme, but due to being an abstract service I couldn't inject that one in the decorator. Another issue is that the setting of the web_path resolver are resolved and injected again in a compiler pass of ImagineBundle, making it harder to get their values in the decorator class. Anyway, not that easy to get an easy fix for this.
Another option is to define a custom resolver for Sylius, which does the work. Still having issues with certain configurations, but it allows for more customisation and own injection points.
The text was updated successfully, but these errors were encountered:
After making sure
framework.assets.base_urls
is used in the ThemeBundle, I found out today that theimagine_filter
is still generating URL's based on the app's base URL, and not on the defined asset URL. This is something ImagineBundle itself also doesn't support, so it's not strictly a Sylius bug. Though, it prevents full usage of a CDN inside Sylius out of the box.I didn't get a working solution yet to decorate the
WebPathResolver
of ImagineBundle. While trying to decorate I wanted to use the UrlPackage of the theme, but due to being an abstract service I couldn't inject that one in the decorator. Another issue is that the setting of theweb_path
resolver are resolved and injected again in a compiler pass of ImagineBundle, making it harder to get their values in the decorator class. Anyway, not that easy to get an easy fix for this.Another option is to define a custom resolver for Sylius, which does the work. Still having issues with certain configurations, but it allows for more customisation and own injection points.
The text was updated successfully, but these errors were encountered: