Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkout] Send confirmation email after checkout is completed #593

Merged
merged 2 commits into from
Nov 12, 2019
Merged

[Checkout] Send confirmation email after checkout is completed #593

merged 2 commits into from
Nov 12, 2019

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Oct 30, 2019 •
edited by mamazu
Loading

Relates #250

@lchrusciel lchrusciel requested a review from a team as a code owner October 30, 2019 16:11
@mamazu
Copy link
Member

mamazu commented Oct 30, 2019 •
edited
Loading

Why don't we trigger the Sylius internal mail for order creation?

@lchrusciel lchrusciel mentioned this pull request Oct 30, 2019
Merged
@Zales0123 Zales0123 added the Bug label Oct 31, 2019
@lchrusciel
Copy link
Member Author

Hey Max,

Recently I came across this issue, and I've tried to solve it the best way. As order confirmation email is placed in ShopBundle, it is better not to use it in ShopAPI plugin, as these two are not compatible atm. Triggering the event is the best way to solve it. I don't want to block anything anymore, so I don't want to refactor everything, but IMHO it makes sense to introduce this concept here and migrate to others if needed.

I've updated my PR with some documentation.

mamazu
mamazu approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@mamazu mamazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well having Sylius without the ShopBundle is impossible anyways as the AdminBundle already needs the ShopBundle, but you are right that in this case a coupling wouldn't be the best solution.

And good work on the documentation.

@lchrusciel lchrusciel merged commit c476d1d into Sylius:master Nov 12, 2019
@lchrusciel lchrusciel deleted the order-confirmation branch November 12, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@mamazu mamazu mamazu approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lchrusciel @mamazu @GSadee @Zales0123