More LoggedInUserProvider implementation and adding phpstan back in #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamazu
force-pushed
the
LoggedInUserProvider
branch
from
827145e
to
575faeb
Compare
mamazu
force-pushed
the
LoggedInUserProvider
branch
from
575faeb
to
6800215
Compare
lchrusciel
approved these changes
Jul 17, 2019
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "id": "@integer@", | |||
There was a problem hiding this comment.
We don't need to expose id to logged in customer
|
Thanks, @mamazu! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the user provider to the
CustomerDetailsActionand adding the phpstan changes back in.