-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed product reviews by product code route by api convention #449
Conversation
Thank you for your contribution and welcome to the community. Your pull request looks great. |
@@ -21,3 +9,15 @@ sylius_shop_api_add_product_review_by_code: | |||
methods: [POST] | |||
defaults: | |||
_controller: sylius.shop_api_plugin.controller.product.add_review_by_code_action | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was that moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/reviews is more specific route so it is moved on top, cause in some situaion routing can consider /reviews as part of slug/code
in this situation that will never happen
and also it is better/faster to have more specific routes on top
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense.
Thank you, Antonio! 🎉 |
No description provided.