Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maintanance] Remove redundant specs #437

Merged
merged 1 commit into from
May 2, 2019
Merged

[Maintanance] Remove redundant specs #437

merged 1 commit into from
May 2, 2019

Conversation

lchrusciel
Copy link
Member

TypeError tests don't provide any value, we are just testing that PHP itself is working correctly

@lchrusciel lchrusciel requested a review from a team as a code owner April 30, 2019 11:38
mamazu
mamazu approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@mamazu mamazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that makes sense.

@GSadee GSadee merged commit db51b80 into Sylius:master May 2, 2019
@GSadee
Copy link
Member

GSadee commented May 2, 2019

Thanks, Łukasz! 🎉

@lchrusciel lchrusciel deleted the remove-redundant-tests branch May 6, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@mamazu mamazu mamazu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lchrusciel @GSadee @mamazu