Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitting up the PHPUnit tests #395

Merged
merged 7 commits into from
Feb 15, 2019
Merged

Splitting up the PHPUnit tests #395

merged 7 commits into from
Feb 15, 2019

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Feb 13, 2019

What is this the pull request about:

  • Splitting the unit tests up in the same folders as the controllers they test
  • Adding return types to the test
  • Adding a JSONTestCase constant to centralize the "content type header" and the "accepts" header

@mamazu mamazu requested a review from a team as a code owner February 13, 2019 17:25
lchrusciel
lchrusciel approved these changes Feb 15, 2019
View reviewed changes
tests/Controller/JsonApiTestCase.php
@@ -6,6 +6,15 @@

abstract class JsonApiTestCase extends \Lakion\ApiTestCase\JsonApiTestCase
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add @internal and some information to not extend this class in end projects

@lchrusciel lchrusciel merged commit 3433f27 into Sylius:master Feb 15, 2019
@lchrusciel
Copy link
Member

Thank you, @mamazu! 🥇

@mamazu mamazu deleted the splitting_up branch March 13, 2019 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mamazu @lchrusciel