Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename legacy tests directory #838

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Rename legacy tests directory #838

merged 4 commits into from
Jan 19, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jan 19, 2024 •
edited
Loading

Q A
Bug fix? yes (on 1.11 branch)
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Then legacyTests directory should contain Sylius\Component\Resource tests
and tests directory should contain Sylius\Resource tests

@loic425 loic425 requested a review from a team as a code owner January 19, 2024 10:31
@loic425 loic425 force-pushed the fix/renamse-legacy-tests branch from 403156a to ff6e14a Compare January 19, 2024 10:37
@loic425 loic425 force-pushed the fix/renamse-legacy-tests branch from ff6e14a to d46c4e6 Compare January 19, 2024 10:37
@GSadee GSadee added Maintenance Configurations, READMEs, releases, etc. DX Issues and PRs aimed at improving Developer eXperience. labels Jan 19, 2024
@GSadee GSadee merged commit 62157f1 into Sylius:1.11 Jan 19, 2024
24 checks passed
@GSadee
Copy link
Member

GSadee commented Jan 19, 2024

Thanks, Loïc! 🥇

@loic425 loic425 deleted the fix/renamse-legacy-tests branch January 19, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @GSadee