Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch pre write event processor #828

Merged

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Dec 18, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

Extracted from #817
It was PreEventDispatcherProcessor but I think it's a better name now.

I've decided to split https://github.com/Sylius/SyliusResourceBundle/blob/1.11/src/Component/src/State/Processor/EventDispatcherProcessor.php into two processors, so this one is the first part of the split.

This processor allows user switching from resource controller to this new system easily.
But we will be able to deprecate this event in the future.

@loic425 loic425 requested a review from a team as a code owner December 18, 2023 13:06
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However I wonder if this single processor shouldn't be responsible for both pre and post events

@lchrusciel lchrusciel merged commit 1500605 into Sylius:1.11 Dec 27, 2023
24 checks passed
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the feature/dispatch-pre-write-event-processor branch January 2, 2024 09:17
GSadee added a commit that referenced this pull request Jan 12, 2024
This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | 
| License         | MIT

Based on #828
Extracted from #817


Commits
-------

aa01fc6 Dispatch post write event processor
c487789 Fix namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants