Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some namespaces on repository #820

Merged
merged 12 commits into from
Jan 19, 2024
Merged

Move some namespaces on repository #820

merged 12 commits into from
Jan 19, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Dec 12, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner December 12, 2023 14:35
diimpp
diimpp reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@diimpp diimpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked around half, will re-read after rebase.

docs/configuration.md Outdated Show resolved Hide resolved
docs/configure_your_operations.md Outdated Show resolved Hide resolved
docs/configure_your_resource.md Outdated Show resolved Hide resolved
docs/create_new_resource.md Outdated Show resolved Hide resolved
docs/redirect.md Outdated Show resolved Hide resolved
docs/resource_factories.md Outdated Show resolved Hide resolved
docs/responders.md Outdated Show resolved Hide resolved
psalm.xml Outdated Show resolved Hide resolved
psalm.xml Outdated Show resolved Hide resolved
src/Component/src/Doctrine/Persistence/Exception/ExistingResourceException.php Outdated Show resolved Hide resolved
@loic425 loic425 force-pushed the move-component-namespace/repository branch from b6d7dd7 to 2d03b3e Compare January 18, 2024 08:05
loic425 and others added 2 commits January 18, 2024 15:39
diimpp
diimpp reviewed Jan 18, 2024
View reviewed changes
docs/resource_factories.md Outdated Show resolved Hide resolved
oallain
oallain approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@oallain oallain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not easy to read but it's seen to be good 🤩

@GSadee GSadee merged commit 51e3672 into Sylius:1.11 Jan 19, 2024
24 checks passed
@GSadee
Copy link
Member

GSadee commented Jan 19, 2024

Thank you, Loïc! 🥇

@loic425 loic425 deleted the move-component-namespace/repository branch January 19, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oallain oallain oallain approved these changes

@GSadee GSadee GSadee approved these changes

@diimpp diimpp diimpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loic425 @GSadee @diimpp @oallain