Move some namespaces on reflection #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
force-pushed
the
move-component-namespace/reflection
branch
from
bbb92e5 to
38db714
Compare
loic425
force-pushed
the
move-component-namespace/reflection
branch
2 times, most recently
from
8bd4def to
65797db
Compare
loic425
force-pushed
the
move-component-namespace/reflection
branch
from
dfcbb0d to
ffeaa37
Compare
diimpp
approved these changes
Dec 11, 2023
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Judging by diff, there is unnecessary empty line at the end.
But in file view it's alright 🤔
| $finder->files()->in($path)->name('*.php')->sortByName(true); | ||
|
|
||
| foreach ($finder as $file) { | ||
| $fileContent = (string) file_get_contents((string) $file->getRealPath()); |
There was a problem hiding this comment.
Suggested change
| $fileContent = (string) file_get_contents((string) $file->getRealPath()); | |
| $fileContent = file_get_contents((string) $file->getRealPath()); |
file_get_contents might return false, so it might be better to handle it explicitly.
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #805
Only ClassReflection needs a bc-layer cause the other classes have been introduced in 1.11.