Move some namespaces on Symfony forms, requests and responses #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic425
commented
Nov 13, 2023
| @@ -15,22 +15,6 @@ | |||
| <services> | |||
| <service id="sylius.resource_factory.expression_language" class="Symfony\Component\ExpressionLanguage\ExpressionLanguage" /> | |||
|
|
|||
| <service id="sylius.resource_factory.argument_parser" class="Sylius\Component\Resource\Factory\ArgumentParser"> | |||
There was a problem hiding this comment.
this one does not existing anymore
loic425
commented
Nov 13, 2023
| </service> | ||
| <service id="Sylius\Component\Resource\Factory\ArgumentParserInterface" alias="sylius.resource_factory.argument_parser" /> | ||
|
|
||
| <service id="sylius.state.provider.event_dispatcher" |
There was a problem hiding this comment.
this service configuration was duplicated
diimpp
approved these changes
Nov 13, 2023
|
Thank you, @loic425! |
lchrusciel
added a commit
that referenced
this pull request
Nov 16, 2023
…ptions and workflow (loic425) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Based on #783 Commits ------- dfe44a2 Move some namespaces on Symfony forms, requests and responses c6a5714 Fix Phpspec tests 1e91439 Fix sylius.repository_argument_resolver.request service dfd0b9c Move some namespaces on Symfony routing, validator exceptions and workflow 73ed8b4 Fix Psalm errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These classes have been introduced on 1.11.