Fix Doctrine subscriber deprecations #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Jul 13, 2023
•
loic425
commented
| Q | A |
|---|---|
| Bug fix? | yes (deprecations) |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes and UPGRADE.md has been updated |
| Related tickets | fixes #736 |
| License | MIT |
loic425
force-pushed
the
fix/doctrine-subscriber-deprecations
branch
from
13bb9f0 to
3491746
Compare
loevgaard
approved these changes
Jul 13, 2023
|
@lchrusciel Maybe should we keep the public methods for user decorations. |
lchrusciel
reviewed
Jul 13, 2023
| @@ -26,7 +24,7 @@ | |||
| use Sylius\Component\Resource\Translation\TranslatableEntityLocaleAssignerInterface; | |||
| use Symfony\Component\DependencyInjection\ContainerInterface; | |||
|
|
|||
| final class ORMTranslatableListener implements EventSubscriber | |||
| final class ORMTranslatableListener | |||
There was a problem hiding this comment.
Suggested change
| final class ORMTranslatableListener | |
| final class ORMTranslatableListener implements AbstractDoctrineSubscriber |
loic425
force-pushed
the
fix/doctrine-subscriber-deprecations
branch
from
3491746 to
c994b84
Compare
lchrusciel
approved these changes
Jul 13, 2023
|
Thank you, @loic425! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.