Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PHPUnit tests from bundle #733

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Move PHPUnit tests from bundle #733

merged 1 commit into from
Jul 20, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jul 7, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner July 7, 2023 09:16
@loic425 loic425 marked this pull request as draft July 7, 2023 09:16
@loic425 loic425 changed the title Move command tests Move PHPUnit tests Jul 7, 2023
@loic425 loic425 changed the title Move PHPUnit tests Move PHPUnit bundle tests Jul 7, 2023
@loic425 loic425 changed the title Move PHPUnit bundle tests Move PHPUnit tests from bundle Jul 7, 2023
@loic425 loic425 marked this pull request as ready for review July 7, 2023 09:54
@loic425 loic425 mentioned this pull request Jul 7, 2023
Closed
@loic425 loic425 force-pushed the feature/move-phpunit-tests branch 2 times, most recently from aa0f36e to 4c28c11 Compare July 18, 2023 07:42
@loic425 loic425 force-pushed the feature/move-phpunit-tests branch from 0d8f2eb to 5f8f75b Compare July 18, 2023 07:56
@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). DX Issues and PRs aimed at improving Developer eXperience. labels Jul 19, 2023
@lchrusciel lchrusciel merged commit 64f2767 into Sylius:1.11 Jul 20, 2023
@lchrusciel
Copy link
Member

Thank you, @loic425!

@loic425 loic425 deleted the feature/move-phpunit-tests branch July 20, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@Prometee Prometee Prometee approved these changes

Assignees
No one assigned
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@loic425 @lchrusciel @Prometee @Zales0123