Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New docs] Configure the resource plural name #689

Merged
merged 2 commits into from
Jun 21, 2023
Merged

[New docs] Configure the resource plural name #689

merged 2 commits into from
Jun 21, 2023

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Apr 6, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #688
License MIT

@loic425 loic425 requested a review from a team as a code owner April 6, 2023 08:23
@loic425 loic425 force-pushed the poc-new-resource-metadata branch 2 times, most recently from b5a7698 to 5ad1d7d Compare June 20, 2023 13:59
@Zales0123 Zales0123 mentioned this pull request Jun 20, 2023
Merged
Zales0123
Zales0123 reviewed Jun 20, 2023
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

docs/configure_your_resource.md Outdated Show resolved Hide resolved
@loic425 loic425 force-pushed the new-docs/configure-the-resource-plural-name branch from 6940004 to efe1240 Compare June 21, 2023 15:12
@loic425 loic425 changed the base branch from poc-new-resource-metadata to poc-rebased June 21, 2023 15:12
loic425 and others added 2 commits June 21, 2023 22:23
@Zales0123 Zales0123 force-pushed the new-docs/configure-the-resource-plural-name branch from efe1240 to 5080334 Compare June 21, 2023 20:23
@Zales0123 Zales0123 merged commit 59d1017 into Sylius:poc-rebased Jun 21, 2023
@Zales0123
Copy link
Member

Thanks, Loïc! 🥇

@loic425 loic425 deleted the new-docs/configure-the-resource-plural-name branch June 21, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

Assignees
No one assigned
Labels
None yet
Projects
New resource documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @Zales0123