Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Pagerfanta 4.0 #634

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Allow Pagerfanta 4.0 #634

merged 1 commit into from
Jul 25, 2023

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Mar 15, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

I tagged Pagerfanta 4.0. It's pretty much B/C with 3.x minus a bit of internal cleanup. For now, both the latest 3.x and 4.0 are allowed to make it possible for the upgrade to start trickling out.

@mbabker mbabker requested a review from a team as a code owner March 15, 2023 22:24
@Zales0123 Zales0123 added the Maintenance Configurations, READMEs, releases, etc. label Jun 22, 2023
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, we should test the package against both Pagerfanta 3.7 and ^4.0... but it would double our builds 🚀 so I vote for merging it, it seems to be quite safe 🖖

@Zales0123
Copy link
Member

Ok, second thought - maybe just add one build with pagerfanta 3.7 to be 99% it works properly?

@mbabker
Copy link
Contributor Author

mbabker commented Jun 22, 2023

If only there were a build using the --prefer-lowest flag to help with this 😅

(I'll get this rebased at some point in the next few days)

@mbabker mbabker force-pushed the feature/pagerfanta-4 branch from c207b82 to 72ed500 Compare July 24, 2023 22:36
@mbabker
Copy link
Contributor Author

mbabker commented Jul 24, 2023

Well, better late than never, finally got this updated.

@mbabker mbabker force-pushed the feature/pagerfanta-4 branch from 72ed500 to 036356f Compare July 24, 2023 22:41
@Zales0123 Zales0123 merged commit 3ff33b6 into Sylius:1.11 Jul 25, 2023
@Zales0123
Copy link
Member

Thank you, @mbabker! 🎉

@mbabker mbabker deleted the feature/pagerfanta-4 branch July 25, 2023 15:38
GSadee added a commit to Sylius/SyliusGridBundle that referenced this pull request Sep 24, 2024
This PR was merged into the 1.13 branch.

Discussion
----------

Requires Sylius/SyliusResourceBundle#634

Commits
-------

92d292a Allow Pagerfanta 4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants