-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Pagerfanta 4.0 #634
Allow Pagerfanta 4.0 #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In theory, we should test the package against both Pagerfanta 3.7
and ^4.0
... but it would double our builds 🚀 so I vote for merging it, it seems to be quite safe 🖖
Ok, second thought - maybe just add one build with pagerfanta 3.7 to be 99% it works properly? |
If only there were a build using the (I'll get this rebased at some point in the next few days) |
c207b82
to
72ed500
Compare
Well, better late than never, finally got this updated. |
72ed500
to
036356f
Compare
Thank you, @mbabker! 🎉 |
This PR was merged into the 1.13 branch. Discussion ---------- Requires Sylius/SyliusResourceBundle#634 Commits ------- 92d292a Allow Pagerfanta 4.0
I tagged Pagerfanta 4.0. It's pretty much B/C with 3.x minus a bit of internal cleanup. For now, both the latest 3.x and 4.0 are allowed to make it possible for the upgrade to start trickling out.