Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flashbag): fixed addFlash in ControllerTrait for Symfony 6 #538

Merged
merged 2 commits into from
Sep 9, 2023
Merged

fix(flashbag): fixed addFlash in ControllerTrait for Symfony 6 #538

merged 2 commits into from
Sep 9, 2023

Conversation

UlrichHP
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #535
License MIT

@UlrichHP UlrichHP requested a review from a team as a code owner December 15, 2022 10:11
@SVillette
Copy link

Hi, friendly ping @loic425 @lchrusciel

Just checked this code, it's part of Symfony AbstractController. Merging this PR would support adding a flash message in the Symfony 6 way.

@loic425
Copy link
Member

loic425 commented Feb 2, 2023

@lchrusciel
https://github.com/symfony/symfony/blob/6.3/src/Symfony/Bundle/FrameworkBundle/Controller/AbstractController.php#L176

@UlrichHP UlrichHP requested review from loic425 and lchrusciel and removed request for loic425 and lchrusciel February 3, 2023 07:53
@loic425
Copy link
Member

loic425 commented Feb 3, 2023

@UlrichHP I've fixed the CI on 1.10 branch, could you rebase please?

@UlrichHP
Copy link
Contributor Author

UlrichHP commented Feb 3, 2023

@loic425 I just did the rebase. It should be good now 😄

@UlrichHP UlrichHP requested a review from lchrusciel February 7, 2023 14:24
@UlrichHP
Copy link
Contributor Author

@lchrusciel is this PR still relevant or do you want me to close it ?

@lchrusciel lchrusciel merged commit c8f12d3 into Sylius:1.10 Sep 9, 2023
@lchrusciel
Copy link
Member

Thank you, @UlrichHP!

@lchrusciel
Copy link
Member

@UlrichHP absolutly! Thanks for the PR. During SyliusDay, I've finally found time for some reviews :)

@UlrichHP UlrichHP deleted the fix-flashbag-symfony-6 branch September 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SVillette SVillette SVillette approved these changes

@Roshyo Roshyo Roshyo approved these changes

@loic425 loic425 loic425 approved these changes

@lchrusciel lchrusciel Awaiting requested review from lchrusciel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@UlrichHP @SVillette @loic425 @lchrusciel @Roshyo