Fix Symfony 6 Exception #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mpysiak
commented
Nov 29, 2022
mpysiak
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | fixes #506 |
| License | MIT |
jakubtobiasz
approved these changes
Dec 2, 2022
| @@ -60,7 +60,7 @@ public function handleRequest(FormInterface $form, mixed $request = null): void | |||
| return; | |||
| } | |||
|
|
|||
| $data = $request->query->get($name); | |||
| $data = $request->query->all()[$name]; | |||
There was a problem hiding this comment.
Suggested change
| $data = $request->query->all()[$name]; | |
| $data = $request->query->all($name); |
Cosmetic change 😅
There was a problem hiding this comment.
@mpysiak note for the future, please either apply suggestions from the comment or answer why you don't want to do so. Please, don't just mark a comment as resolved without anything in it
There was a problem hiding this comment.
@lchrusciel sorry, it was my first PR 😉
There was a problem hiding this comment.
@lchrusciel, it looks like this "cosmetic change" breaks in SF 5.4. Although it works in SF6. It produces an error
Unexpected value for parameter "xxx": expecting "array", got "string"
It works fine if I revert back to
$data = $request->query->all()[$name];
Co-authored-by: Jakub Tobiasz <80641364+jakubtobiasz@users.noreply.github.com>
lchrusciel
approved these changes
Dec 2, 2022
|
Hey MIchał, thank you very much for the PR! 🎉 And welcome among other Sylius contributors! :) |
GSadee
added a commit
that referenced
this pull request
Jun 20, 2024
…nseMate) This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #876, followup of #507 | License | MIT Keeping the way we access the parameters bag the same way it's done in the base class. Refs: - https://github.com/symfony/form/blob/5.4/Extension/HttpFoundation/HttpFoundationRequestHandler.php - https://github.com/symfony/form/blob/6.4/Extension/HttpFoundation/HttpFoundationRequestHandler.php Commits ------- cedee23 Fix form parameter bags accesing in request handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.