Add services' aliases to improve autowiring experience #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Nov 14, 2022
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
loic425
commented
Nov 14, 2022
Roshyo
reviewed
Nov 14, 2022
Roshyo
approved these changes
Nov 14, 2022
lchrusciel
approved these changes
Nov 25, 2022
loic425
force-pushed
the
feature/add-services-aliases
branch
from
96d0aaa to
95fd4c1
Compare
lchrusciel
approved these changes
Nov 28, 2022
| @@ -19,40 +19,69 @@ | |||
| <argument type="service" id="service_container" /> | |||
| <argument type="service" id="sylius.expression_language" /> | |||
| </service> | |||
| <service id="Sylius\Bundle\ResourceBundle\Controller\ParametersParserInterface" alias="sylius.resource_controller.parameters_parser" public="false" /> | |||
There was a problem hiding this comment.
Can we reverse this definition? So the interface will be on a service itself and sylius.resource_controller.parameters_parser will alias to it? Same as requested: Sylius/SyliusGridBundle#279 (comment)
lchrusciel
added
Feature
mbabker
reviewed
Nov 29, 2022
| <argument type="service" id="sylius.resource_registry" /> | ||
| <tag name="console.command" /> | ||
| </service> | ||
| <service id="sylius.console.command.resource_debug" alias="Sylius\Bundle\ResourceBundle\Command\DebugResourceCommand" /> |
There was a problem hiding this comment.
@loic425 @lchrusciel Changes like this one could technically be a B/C break. You're changing a service ID from a definition to an alias. Granted, with this specific case, it's probably not a big deal, but if someone were doing something in a compiler pass, a $container->getDefinition('sylius.console.command.resource_debug') call would no longer work.
GSadee
added a commit
that referenced
this pull request
Jan 4, 2023
This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Replace #549 Fix the BC-break from #498 Commits ------- 947dc82 Flip back service ids and FQCN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.