Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource alias, always return 2 array items #474

Merged
merged 3 commits into from
Aug 12, 2022
Merged

Resource alias, always return 2 array items #474

merged 3 commits into from
Aug 12, 2022

Conversation

Prometee
Copy link
Contributor

@Prometee Prometee commented Aug 9, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #473
License MIT

This PR fix #473

@Prometee Prometee requested a review from a team as a code owner August 9, 2022 14:27
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix the build first

@Prometee
Copy link
Contributor Author

@lchrusciel build errors are fixed now 😉

@lchrusciel lchrusciel changed the base branch from 1.10 to 1.9 August 11, 2022 21:57
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "more-than-2-dots" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@lchrusciel
Copy link
Member

I've moved your fix to 1.9, to have it available earlier, but can you add one more spec case here: https://github.com/Sylius/SyliusResourceBundle/blob/1.9/src/Component/spec/Metadata/MetadataSpec.php, to avoid regression in future?

@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Aug 12, 2022
@GSadee GSadee merged commit 08f94b4 into Sylius:1.9 Aug 12, 2022
@GSadee
Copy link
Member

GSadee commented Aug 12, 2022

Thank you, Francis! 🎉

@Prometee
Copy link
Contributor Author

I've moved your fix to 1.9, to have it available earlier, but can you add one more spec case here: https://github.com/Sylius/SyliusResourceBundle/blob/1.9/src/Component/spec/Metadata/MetadataSpec.php, to avoid regression in future?

@lchrusciel sure I will open an other PR based on 1.9 this time 😉

@Prometee Prometee deleted the more-than-2-dots branch August 12, 2022 12:54
@Prometee
Copy link
Contributor Author

@lchrusciel arf you were faster than me 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource naming with more than 2 dots
4 participants