-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource alias, always return 2 array items #474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix the build first
@lchrusciel build errors are fixed now 😉 |
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
I've moved your fix to 1.9, to have it available earlier, but can you add one more spec case here: https://github.com/Sylius/SyliusResourceBundle/blob/1.9/src/Component/spec/Metadata/MetadataSpec.php, to avoid regression in future? |
Thank you, Francis! 🎉 |
@lchrusciel sure I will open an other PR based on 1.9 this time 😉 |
@lchrusciel arf you were faster than me 😆 |
This PR fix #473