Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix route loaders #365

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Fix route loaders #365

merged 1 commit into from
Feb 2, 2022

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Feb 2, 2022

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

Without this interface, the routes are not re-generating on a change without clearing the cache.

@loic425 loic425 requested a review from a team as a code owner February 2, 2022 21:44
@lchrusciel lchrusciel added Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience. labels Feb 2, 2022
@lchrusciel lchrusciel merged commit 8326f4c into Sylius:master Feb 2, 2022
@lchrusciel
Copy link
Member

Thank you, Loïc! 🥇

@loic425 loic425 deleted the fix/route-loaders branch February 2, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvasiloi vvasiloi vvasiloi approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loic425 @lchrusciel @vvasiloi