Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use deprecated Twig spaceless tag #333

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Don't use deprecated Twig spaceless tag #333

merged 1 commit into from
Nov 9, 2021

Conversation

stloyd
Copy link
Contributor

@stloyd stloyd commented Nov 6, 2021 •
edited
Loading

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #331
License MIT

@stloyd stloyd requested a review from a team as a code owner November 6, 2021 15:11
@stloyd
Copy link
Contributor Author

stloyd commented Nov 8, 2021

@lchrusciel @GSadee Can you check this one? :)

@lchrusciel lchrusciel merged commit db5bd30 into Sylius:master Nov 9, 2021
@lchrusciel
Copy link
Member

Thank you, Joseph! 🎉

@lchrusciel lchrusciel added the Bug Confirmed bugs or bugfixes. label Nov 9, 2021
@stloyd stloyd deleted the patch-1 branch November 9, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roshyo Roshyo Roshyo approved these changes

@loic425 loic425 loic425 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Twig 3 Compatibility Issue
4 participants
@stloyd @lchrusciel @loic425 @Roshyo