Remove winzou state machine dependency #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
loic425
commented
Oct 14, 2020
loic425
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
loic425
force-pushed
the
feature/remove-winzou-state-machine-dependency
branch
4 times, most recently
from
37fac4a to
b6f4875
Compare
loic425
changed the title
loic425
changed the title
loic425
changed the title
|
@pamil This one is ready, I will make the second part (upgrading the test app) on another PR. |
loic425
force-pushed
the
feature/remove-winzou-state-machine-dependency
branch
from
b6f4875 to
671d393
Compare
Closed
loic425
commented
Oct 16, 2020
| }, | ||
| "replace": { | ||
| "sylius/resource": "self.version" | ||
| }, | ||
| "conflict": { | ||
| "friendsofsymfony/rest-bundle": "<3.0 >=4.0", | ||
| "jms/serializer-bundle": "<3.5 >=4.0", | ||
| "willdurand/hateoas-bundle": "<2.0 >=3.0" | ||
| "willdurand/hateoas-bundle": "<2.0 >=3.0", | ||
| "winzou/state-machine-bundle": "<0.3.2 || >=0.4.0 <0.4.3" |
There was a problem hiding this comment.
@pamil I'm not sure at all for "<0.3.2 || >=0.4.0 <0.4.3", Can you confirm it?
loic425
commented
Oct 16, 2020
| @@ -16,28 +16,14 @@ | |||
|
|
|||
| class AppKernel extends Kernel | |||
| { | |||
| public function registerBundles() | |||
| public function registerBundles(): iterable | |||
There was a problem hiding this comment.
@pamil I just use that part of new Symfony architecture to have something easier with all environments on travis to test optional bundles.
This was referenced Oct 19, 2020
Merged
pamil
approved these changes
Nov 5, 2020
| }, | ||
| "replace": { | ||
| "sylius/resource": "self.version" | ||
| }, | ||
| "conflict": { | ||
| "friendsofsymfony/rest-bundle": "<3.0 >=4.0", | ||
| "jms/serializer-bundle": "<3.5 >=4.0", | ||
| "willdurand/hateoas-bundle": "<2.0 >=3.0" | ||
| "willdurand/hateoas-bundle": "<2.0 >=3.0", | ||
| "winzou/state-machine-bundle": "<0.3.2 || >=0.4.0 <0.4.3" |
pamil
suggested changes
Nov 5, 2020
pamil
force-pushed
the
feature/remove-winzou-state-machine-dependency
branch
from
3054cae to
917f40b
Compare
|
Rebased with master and ported Travis CI changes to GitHub Actions 🎉 |
pamil
force-pushed
the
feature/remove-winzou-state-machine-dependency
branch
from
917f40b to
7bb221d
Compare
|
Thank you, Loïc! 🥇 |
pamil
added a commit
that referenced
this pull request
Nov 5, 2020
This PR was merged into the 1.7-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT depends on #202 Commits ------- 2531d31 [WIP] Remove twig bundle dependency 83606fb Trying to fix test app conf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.