Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build #181

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Fix build #181

merged 3 commits into from
Sep 9, 2020

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Sep 8, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@loic425 loic425 requested a review from a team as a code owner September 8, 2020 08:44
@loic425 loic425 changed the title set Kernel.bundles on pagerfanta extension test Fix build Sep 8, 2020
@loic425
Copy link
Member Author

loic425 commented Sep 8, 2020

@lchrusciel What do you think about these fixes?

lchrusciel
lchrusciel reviewed Sep 8, 2020
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Loic,

thanks for your work and fixes seem ok. However, I'm wondering why do we need to bump the state machine version? Not a big deal, but we are using 0.3 in Sylius right now.

composer.json Outdated
@@ -39,7 +39,7 @@
"symfony/validator": "^4.4|^5.0",
"symfony/yaml": "^4.4|^5.0",
"willdurand/hateoas-bundle": "^2.0",
"winzou/state-machine-bundle": "^0.3|^0.4"
"winzou/state-machine-bundle": "^0.4.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug on winzou with dependencies between state-machine and state-machine bundle. Maybe there's something better to do:
"winzou/state-machine-bundle": "^0.3.2|^0.4.3"
I'm gonna try that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lchrusciel But I think we have to improve CI configuration to test these two state machine versions.

@lchrusciel lchrusciel merged commit d494fd6 into Sylius:master Sep 9, 2020
@lchrusciel
Copy link
Member

Thanks, Loïc! 🥇

@loic425 loic425 deleted the fix/build branch September 9, 2020 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @lchrusciel