Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagerfanta updates #177

Merged
merged 4 commits into from
Oct 14, 2020
Merged

Pagerfanta updates #177

merged 4 commits into from
Oct 14, 2020

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Aug 31, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

As noted here, the latest version of the Pagerfanta package was restructured to support separately installed sub-packages. So, to help with avoiding deprecation notices and preparing for compatibility with the new major version I expect to push out toward the end of the year, I've bumped the Pagerfanta minimums up to the latest versions, updated the query adapter classes to use the non-deprecated classes, and changed the component to install only the pagerfanta/core sub-package since that's all it directly depends on.

@mbabker mbabker requested a review from a team as a code owner August 31, 2020 22:48
@lchrusciel
Copy link
Member

We have to fix the main build before we can go anywhere further.

@lchrusciel lchrusciel linked an issue Sep 9, 2020 that may be closed by this pull request
@pamil pamil merged commit 297c551 into Sylius:master Oct 14, 2020
@pamil
Copy link
Contributor

pamil commented Oct 14, 2020

Thank you, Michael! 🎉

@mbabker mbabker deleted the pagerfanta-updates branch October 14, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony 5 support
3 participants