Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if form is submitted on resource creation/edition #172

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Check if form is submitted on resource creation/edition #172

merged 2 commits into from
Aug 31, 2020

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Jul 3, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets fixes #171
License MIT

@loic425 loic425 requested a review from a team as a code owner July 3, 2020 14:17
@lchrusciel lchrusciel merged commit 29e9c88 into Sylius:master Aug 31, 2020
@lchrusciel
Copy link
Member

Thanks, Loïc! 🥇

@loic425 loic425 deleted the fix/check-if-form-is-submitted branch August 31, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@stloyd stloyd stloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LogicException when submitting invalid (empty) fields for resource creation
3 participants
@loic425 @lchrusciel @stloyd