Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for DoctrineBundle ^2.0 #135

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jan 2, 2020

Related to #121.
The only class we use in ResourceBundle has not been changed in 2.0, so we can support both at the same time.

@pamil pamil added the Maintenance Configurations, READMEs, releases, etc. label Jan 2, 2020
@loic425 loic425 mentioned this pull request Jan 3, 2020
@Zales0123 Zales0123 merged commit 68eefef into Sylius:master Jan 3, 2020
@Zales0123
Copy link
Member

Thanks, Kamil! 🥇

pamil added a commit to Sylius/Sylius that referenced this pull request Dec 31, 2020
… ResourceBundle reqs (stloyd)

This PR was merged into the 1.9-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master <!-- see the comment below -->
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | related #10928 + Sylius/SyliusResourceBundle#135
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.7 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

6901617 Allow newer "doctrine/doctrine-bundle" to match upcoming ResourceBundle reqs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants