Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating composer dependencies #114

Merged
merged 5 commits into from
Jan 1, 2020
Merged

Updating composer dependencies #114

merged 5 commits into from
Jan 1, 2020

Conversation

mamazu
Copy link
Member

@mamazu mamazu commented Nov 28, 2019

The lakion/api-test-case package is now replaced with it's successor.

Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

composer.json Outdated Show resolved Hide resolved
Co-Authored-By: Łukasz Chruściel <lchrusciel@gmail.com>
@mamazu
Copy link
Member Author

mamazu commented Dec 1, 2019

I think the build job failed for some reason. Could you restart it?

@lchrusciel
Copy link
Member

done

@lchrusciel
Copy link
Member

Ah, this container was removed from dependencies and added as a suggestion. That's why it's failing.

Ref. https://github.com/lchrusciel/ApiTestCase/blob/master/UPGRADE.md#upgrading-from-v3-to-v4

@mamazu
Copy link
Member Author

mamazu commented Dec 4, 2019

@pamil This is the new way of doing things. However to preserve backwards compatibilty the all function that psalm complains about already has documentation like that.

@pamil pamil merged commit 84a8c7a into Sylius:master Jan 1, 2020
@pamil
Copy link
Contributor

pamil commented Jan 1, 2020

Thanks, @mamazu! 🎉

@mamazu mamazu deleted the composer branch April 28, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants