Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix autojoining with multiple aliases #35

Merged
merged 3 commits into from
Jan 2, 2020
Merged

Fix autojoining with multiple aliases #35

merged 3 commits into from
Jan 2, 2020

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jan 2, 2020

Fixes #28, see the issue for bug description.

@pamil pamil force-pushed the join-with-existing-alias branch from aa6aff0 to 0822c8a Compare January 2, 2020 14:44
@pamil pamil added the Bug Confirmed bugs or bugfixes. label Jan 2, 2020
@pamil pamil merged commit 8d7c7e7 into Sylius:master Jan 2, 2020
@pamil pamil deleted the join-with-existing-alias branch January 2, 2020 15:26
@waaghals waaghals mentioned this pull request Jan 16, 2020
Closed
@GSadee GSadee mentioned this pull request Apr 14, 2020
Merged
lchrusciel added a commit that referenced this pull request Apr 14, 2020
@lchrusciel
bug #55 Revert "Fix autojoining with multiple aliases" (pamil)
75b1971 
This PR was merged into the 1.6-dev branch.

Discussion
----------

We need to revert the changes from #35 because they cause the other issue (#42), but we definitely need to solve all these problems correctly.

Commits
-------

8d8083c Revert "Fix autojoining with multiple aliases"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pamil