Add embeddable support #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
embeddable-support
branch
from
512efdc to
c2dc83d
Compare
pamil
force-pushed
the
embeddable-support
branch
from
c2dc83d to
b86d605
Compare
GSadee
approved these changes
Oct 17, 2019
src/Bundle/test/src/AppBundle/Resources/config/doctrine/Price.orm.yml
Outdated
Show resolved
Hide resolved
pamil
force-pushed
the
embeddable-support
branch
from
493e215 to
ee6ee68
Compare
GSadee
approved these changes
Oct 17, 2019
lchrusciel
reviewed
Oct 17, 2019
| continue; | ||
| } | ||
| /** @var Join[] $joins */ | ||
| $joins = array_merge([], ...array_values($this->queryBuilder->getDQLPart('join'))); |
There was a problem hiding this comment.
array_merge([], ...array_values($this->queryBuilder->getDQLPart('join'))); maybe it could be some (even private static) helper function at the end of file with meaningful name like flattenArray?
lchrusciel
reviewed
Oct 17, 2019
| @@ -26,7 +26,8 @@ | |||
| "id": "@integer@", | |||
| "name": "American" | |||
| } | |||
| } | |||
| }, | |||
| "price": "@array@" | |||
There was a problem hiding this comment.
Shouldn't we assert values here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.