Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Behat] Remove final on product index and product variant index pages #10776

Merged
merged 1 commit into from
Oct 18, 2019
Merged

[Behat] Remove final on product index and product variant index pages #10776

merged 1 commit into from
Oct 18, 2019

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Oct 17, 2019

Q A
Branch? 1.5
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

All Behat pages are not final except these two pages. Behat pages need to be extended easily with override method.

@loic425 loic425 requested a review from a team as a code owner October 17, 2019 10:19
@pamil pamil added the Behat Issues and PRs aimed at improving Behat usage. label Oct 18, 2019
@pamil pamil merged commit e028574 into Sylius:1.5 Oct 18, 2019
@pamil
Copy link
Contributor

pamil commented Oct 18, 2019

Thank you, Loïc! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pamil pamil pamil approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic425 @pamil