Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused service #10338

Merged
merged 1 commit into from
Apr 26, 2019
Merged

Removing unused service #10338

merged 1 commit into from
Apr 26, 2019

Conversation

loevgaard
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? I wouldn't say so (see my comment below)
Deprecations? no
License MIT

The service isn't used anywhere and if it would be used it wouldn't work since the Sylius\Component\Shipping\Checker\RuleCheckerInterface does not exist.

@loevgaard loevgaard requested a review from a team as a code owner April 25, 2019 13:50
@Zales0123 Zales0123 added the Potential Bug Potential bugs or bugfixes, that needs to be reproduced. label Apr 25, 2019
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be fixed on 1.3 instead of master?

@loevgaard
Copy link
Contributor Author

Hi @GSadee

It is not a bug, feature or anything. Just something that isn't used, so I guess it isn't necessary. At least that's my opinion :)

The service isn't used anywhere and if it would be used it wouldn't work since the `Sylius\Component\Shipping\Checker\RuleCheckerInterface` does not exist.
@lchrusciel lchrusciel changed the base branch from master to 1.3 April 26, 2019 06:45
@lchrusciel
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "patch-1" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@pamil pamil merged commit a93926e into Sylius:1.3 Apr 26, 2019
@pamil
Copy link
Contributor

pamil commented Apr 26, 2019

Thank you, Joachim! 🥇

@loevgaard loevgaard deleted the patch-1 branch April 26, 2019 06:57
@loevgaard
Copy link
Contributor Author

You're welcome. Always a pleasure to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Potential bugs or bugfixes, that needs to be reproduced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants