-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing unused service #10338
Removing unused service #10338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be fixed on 1.3
instead of master
?
Hi @GSadee It is not a bug, feature or anything. Just something that isn't used, so I guess it isn't necessary. At least that's my opinion :) |
The service isn't used anywhere and if it would be used it wouldn't work since the `Sylius\Component\Shipping\Checker\RuleCheckerInterface` does not exist.
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
Thank you, Joachim! 🥇 |
You're welcome. Always a pleasure to help |
The service isn't used anywhere and if it would be used it wouldn't work since the
Sylius\Component\Shipping\Checker\RuleCheckerInterface
does not exist.