Add Support for Symfony 6 #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMilek
force-pushed
the
SYL-2534
branch
2 times, most recently
from
9f5e2f3
to
58aa0a9
Compare
loic425
approved these changes
Dec 19, 2022
jakubtobiasz
approved these changes
Dec 21, 2022
coldic3
reviewed
Dec 22, 2022
.github/workflows/build.yml
Outdated
| php: [8.0, 8.1] | ||
| node: [10.x] | ||
| mysql: [5.7, 8.0] | ||
| symfony: [^4.4, ~5.2.0, ~5.3.0] |
There was a problem hiding this comment.
I think I told you about it already that it is IMO a good idea to drop SF 4.4 in a separate PR. But if you want to keep it as it is, let's add it at least to the PR title to have this info in the generated changelog on next release 😀
TheMilek
force-pushed
the
SYL-2534
branch
2 times, most recently
from
9102c29
to
f6a6153
Compare
coldic3
approved these changes
Jan 10, 2023
...s/Expected/address_book/SF6/validation_create_address_book_with_wrong_province_response.json
Outdated
Show resolved
Hide resolved
...es/Expected/address_book/SF6/validation_create_address_book_with_wrong_country_response.json
Outdated
Show resolved
Hide resolved
coldic3
approved these changes
Jan 12, 2023
GSadee
approved these changes
Jan 12, 2023
Comment on lines
+114
to
+118
| if (Kernel::VERSION_ID < 60000) { | ||
| $this->assertResponse($response, 'address_book/SF5/validation_create_address_book_with_wrong_country_response', Response::HTTP_BAD_REQUEST); | ||
| } else { | ||
| $this->assertResponse($response, 'address_book/SF6/validation_create_address_book_with_wrong_country_response', Response::HTTP_BAD_REQUEST); | ||
| } |
There was a problem hiding this comment.
To avoid that, we could probably define the custom validation message
|
Thanks, Kamil! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuation of / to potential merge after merging #734